Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: auto fill content in store's files #908

Merged
merged 4 commits into from
Jul 19, 2021
Merged

feat: auto fill content in store's files #908

merged 4 commits into from
Jul 19, 2021

Conversation

GiveMe-A-Name
Copy link
Contributor

  • auto fill content in store's files
  • auto fill content in the files in models folder

autofillcontentInStore

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021 •
edited
Loading

Codecov Report

Merging #908 (5a10be4) into release/1.3.0 (2a1eac4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/1.3.0     #908   +/-   ##
==============================================
  Coverage          57.14%   57.14%           
==============================================
  Files                  1        1           
  Lines                 70       70           
  Branches              15       15           
==============================================
  Hits                  40       40           
  Misses                30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a1eac4...5a10be4. Read the comment docs.

luhc228
luhc228 reviewed Jul 19, 2021
View reviewed changes
extensions/material-helper/src/autoFillContent/autoFillInStore.ts Outdated
const renderFileAsync = util.promisify(ejs.renderFile);
const writeFileAsync = util.promisify(fs.writeFile);

enum createFileTypes {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

枚举命名推荐首字母大写？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

extensions/material-helper/src/autoFillContent/autoFillInStore.ts Outdated
enum createFileTypes {
null,
store,
inModels,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inModels 感觉命名怪怪的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

extensions/material-helper/src/autoFillContent/autoFillInStore.ts Show resolved Hide resolved
extensions/material-helper/src/templates/store.ts.ejs Show resolved Hide resolved
@GiveMe-A-Name GiveMe-A-Name merged commit 3f2acd8 into release/1.3.0 Jul 19, 2021
@fyangstudio fyangstudio mentioned this pull request Jul 21, 2021
Merged
@fyangstudio fyangstudio deleted the feat/auto-fill-content-with-store branch July 23, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhc228 luhc228 luhc228 approved these changes

@fyangstudio fyangstudio Awaiting requested review from fyangstudio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GiveMe-A-Name @codecov-commenter @luhc228