Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove @ali/publish-visual extension #938

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

luhc228
Copy link
Contributor

@luhc228 luhc228 commented Aug 25, 2021

移除在 O2 上对 DEF 可视化发布插件的依赖,避免升级维护的成本

].map((otherExtension4pack) => ({ ...otherExtension4pack, extensionName: camelCase(otherExtension4pack.packageName), isOther: true }));
const otherExtensions: OtherExtension[] = [];

export const otherExtensions4pack = otherExtensions.map((otherExtension4pack) => (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经是空数组了 下面的逻辑 可以注释掉了吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. 对以前的内容增加了注释

@codecov-commenter
Copy link

Codecov Report

Merging #938 (cdb5af6) into release/1.4.1 (50f2664) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/1.4.1     #938   +/-   ##
==============================================
  Coverage          57.14%   57.14%           
==============================================
  Files                  1        1           
  Lines                 70       70           
  Branches              18       18           
==============================================
  Hits                  40       40           
  Misses                30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f2664...cdb5af6. Read the comment docs.

@fyangstudio fyangstudio merged commit 88a1d5e into release/1.4.1 Aug 25, 2021
@fyangstudio fyangstudio deleted the chore/remove-@ali/publish-visual-extension branch August 25, 2021 09:06
@fyangstudio fyangstudio mentioned this pull request Aug 25, 2021
luhc228 added a commit that referenced this pull request Aug 26, 2021
* chore: remove @ali/publish-visual extension (#938)

* chore: remove @ali/publish-visual extension

* fix: material-help (#944)

* fix: material-help (#946)

* fix: material-help

* chore: add @ali/publish-visual to o2 pack (#948)

* fix: import duplicate components when add routers (#947)

* fix: import duplicate components when add routers

* chore: remove comment

* feat: update feedbackLink (#940)

* feat: remove deprecated extension (#939)

* fix: fail to remove compoennt (#942)

Co-authored-by: yangfan <18767120422@163.com>

* feat: add extensionDependencies (#945)

* feat: update version and changelog (#941)

* feat: update version and changelog

* feat: update changelog

* feat: update

* fix: remove referenced identifiers (#949)

Co-authored-by: Hengchang Lu <44047106+luhc228@users.noreply.github.com>
Co-authored-by: qixuan <58852732+GiveMe-A-Name@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants