-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type in products #141
Add type in products #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't retroactively change migrations. You need a new migration to add the column.
Can you link the documentation for this field? Or update the one we have? https://kb.vshn.ch/appuio-cloud/references/architecture/metering-data-flow.html
Ah I see, it's like with percona tools. Understood.
Thanks for directions, I was very much unsure what has to be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link the docs?
I have no idea what this field is for without the context you have. cc @corvus-ch
I will create a PR soon in the docs. Meanwhile you can wait approving this PR.
Well we need it for reporting dashboards. The goal is internal to team Schedar. Aldebaran also might want to apply some kind of groupings to its products. The value is not mandatory. |
That is a dangerous path to go. We must be really cautious about what we add to the billing system and why. Note that there is already some, although implicit, grouping available: the source string of products. If segmenting of the product's source string is done right, it could be used to build grouping. |
I personally don't see any issues with this new column, it will greatly reduce the complexity of queries and will eliminate the need to update grafana dashboards. I don't see a good alternative but we can have a short call to dive into this topic as I am not expert with our billing solution. |
We decided to go with a different approach - changing the source string. Closing this PR |
Summary
This PR adds column
type
to theproducts
table. Thetype
column groups a set of targets. For instance products with target 2, 8 and 10 is of typeappcat
.Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog