Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product name for appcat #142

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Update product name for appcat #142

merged 1 commit into from
Jun 7, 2023

Conversation

zugao
Copy link
Contributor

@zugao zugao commented Jun 6, 2023

Summary

  • Update product names for appcat products. This PR is required to distinguish appuio from appcat products.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@zugao zugao added the change label Jun 6, 2023
@zugao zugao requested a review from a team as a code owner June 6, 2023 08:21
@zugao zugao requested a review from Kidswiss June 6, 2023 08:21
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test if the queries now render with all the right values?

@zugao
Copy link
Contributor Author

zugao commented Jun 6, 2023

Did you test if the queries now render with all the right values?

Yes I did!

Copy link
Contributor

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to manually run the --seeds from what I remember both the old and the new products should be in the database after that. Which is correct - removing an old product would also delete all data points. You might want to switch over from old to new at the beginning of the month and recalculate (delete old ones, run report from midnight the 1.) the datapoints for this month.

You might also be successful renaming the query in the database.

Just make sure you don't double bill.

@zugao zugao merged commit 6180161 into master Jun 7, 2023
3 checks passed
@zugao zugao deleted the update-appcat-product branch June 7, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants