Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update to Angular 16 #549

Merged
merged 19 commits into from
Aug 10, 2023
Merged

⬆️ Update to Angular 16 #549

merged 19 commits into from
Aug 10, 2023

Conversation

steffinchen
Copy link
Contributor

Summary

  • Angular 15 -> Angular 16
  • Migrate to standalone components
  • add required: true to @Input() where sensible
  • Upgrade all other npm packages
  • Format everything with prettier

Closing #548

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@steffinchen steffinchen added change Generic change that is neither a fix or feature dependency Depedency update labels Aug 9, 2023
@steffinchen steffinchen self-assigned this Aug 9, 2023
@steffinchen steffinchen requested review from a team and corvus-ch as code owners August 9, 2023 06:40
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

🚀 Preview deployment active

App URL https://portal-pr-549-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision 26368a2
Helm release appuio-control-api-preview/portal-pr-549
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

Copy link
Member

@corvus-ch corvus-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future, please do bigger formatting changes on its own. It makes it easier to review if one can review for format or functional changes only. In a mixed bag, you have to constantly ask, is this formatting (I do not care) or is this functional (that is the stuff I want to look closer).

@steffinchen steffinchen merged commit 88b44dc into master Aug 10, 2023
6 checks passed
@steffinchen steffinchen deleted the angular-16 branch August 10, 2023 07:01
@steffinchen steffinchen temporarily deployed to preview August 10, 2023 07:01 — with GitHub Actions Inactive
@github-actions
Copy link

✔️ Preview deployment uninstalled

Helm release appuio-control-api-preview/portal-pr-549
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Generic change that is neither a fix or feature dependency Depedency update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants