Switch fetching of fluentd alert YAML file to lookup map #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
fix/collector-rules-release-5.5
branch
from
18d01e7
to
1569cb9
Compare
simu
force-pushed
the
feat/param-version
branch
2 times, most recently
from
f4de671
to
7aa32df
Compare
simu
force-pushed
the
fix/collector-rules-release-5.5
branch
from
1569cb9
to
b513aff
Compare
simu
force-pushed
the
feat/param-version
branch
2 times, most recently
from
834f103
to
2f8356a
Compare
simu
force-pushed
the
fix/collector-rules-release-5.5
branch
from
b513aff
to
5af9568
Compare
We need to specify different locations of the fluentd alerts YAML file in the upstream repository based on the logging stack release, as the file got moved to `files/collector/fluentd_prometheus_alerts.yaml` for release 5.5. We implement this as a lookup map in the component class. Because we don't have a way to implement a fallback value for keys which aren't present in the lookup map, this change removes out-of-the-box support for future logging stack versions.
simu
force-pushed
the
fix/collector-rules-release-5.5
branch
from
3bbe8dd
to
9f67c21
Compare
bastjan
approved these changes
Nov 11, 2022
Rendered from template version: main (86f5428)
simu
force-pushed
the
fix/collector-rules-release-5.5
branch
from
9f67c21
to
d74504b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to specify different locations of the fluentd alerts YAML file in the upstream repository based on the logging stack release, as the file got moved to
files/collector/fluentd_prometheus_alerts.yamlfor release 5.5.We implement this as a lookup map in the component class. Because we don't have a way to implement a fallback value for keys which aren't present in the lookup map, this change removes out-of-the-box support for future logging stack versions.
Fixes #69
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.