Redeem invitations #101
Merged
Redeem invitations #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The redeem endpoint now only defines what has to be done, offloads the work to the controller.
simu
approved these changes
Feb 16, 2023
glrf
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reference: https://kb.vshn.ch/appuio-cloud/references/architecture/control-api-invitation.html#_accepting_an_invitation
This PR adds a
REDEEMendpoint to the invitation storage and adds a controller to handle adding the user to the specified targets.The
REDEEMendpoint adds a snapshot of the requested permissions to the status of the invitation and marks the invitation as redeemed.The controller watches the snapshot and adds the user that has redeemed the invitation to the requested targets.
Note: Validation of those targets is out-of-scope and will be done in another ticket.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.