Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cloudscale.ch installation instructions to include Puppet-managed LoadBalancers #96

Merged
merged 16 commits into from
Jul 20, 2021
Merged

Update cloudscale.ch installation instructions to include Puppet-managed LoadBalancers #96

merged 16 commits into from
Jul 20, 2021

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented Jul 12, 2021 •
edited

  • Updates the installation guide for cloudscale to include Puppet-managed Load balancers
  • Consolidates many common steps into Antora partials
  • Adjusts Exoscale with the partials

Closes #92
Closes #91

@ccremer
Change syntax highlight to bash
d7385ba 
It looks much better with the current style
@ccremer
Add subsections to install syn and finalize
b8da12d 
It makes a better mental break
@ccremer ccremer marked this pull request as ready for review July 16, 2021 15:16
@ccremer ccremer requested a review from simu July 16, 2021 15:16
simu
simu requested changes Jul 16, 2021
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I left some suggestions for removing the references to the storage nodes for cloudscale.

docs/modules/ROOT/pages/how-tos/cloudscale/install.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/cloudscale/install.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/cloudscale/install.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/exoscale/install.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/partials/install/bootstrap-nodes.adoc Show resolved Hide resolved
docs/modules/ROOT/partials/install/bootstrap-nodes.adoc Outdated Show resolved Hide resolved
@ccremer
More consolidating
dbbe856
@ccremer
Make script snippets compatible with bash and zsh
a66de40 
There are a bunch of differences regarding arrays between the 2 shells.
@ccremer
Ignore storage count variables for cloudscale
caa2a39 
It could create confusion even though doesn't do anything.
@ccremer ccremer requested a review from simu July 19, 2021 11:17
simu
simu approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

docs/modules/ROOT/pages/how-tos/cloudscale/decommission.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/cloudscale/install.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/exoscale/install.adoc Show resolved Hide resolved
docs/modules/ROOT/partials/install/finalize.adoc Show resolved Hide resolved
docs/modules/ROOT/partials/setup_terraform.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/cloudscale/install.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/exoscale/install.adoc Outdated Show resolved Hide resolved
@ccremer
Move terraform.env to top-level dir
82575f3 
This avoids having to recreate it after catalog compilation
@ccremer ccremer mentioned this pull request Jul 19, 2021
Merged
3 tasks
@ccremer ccremer merged commit ad570a1 into master Jul 20, 2021
@ccremer ccremer deleted the cloudscale-docs-lb branch July 20, 2021 13:50
@ccremer ccremer mentioned this pull request Jul 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ccremer @simu