Skip to content

Commit

Permalink
Remove linting and test execution from release config
Browse files Browse the repository at this point in the history
  • Loading branch information
bittner committed Apr 27, 2020
1 parent 72c8386 commit de8b800
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Expand Up @@ -11,7 +11,7 @@ on:
types: [opened, reopened]

jobs:
goreleaser:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/lint.yml
Expand Up @@ -11,7 +11,7 @@ on:
types: [opened, reopened]

jobs:
go-fmt:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
Expand All @@ -22,7 +22,5 @@ jobs:
with:
path: /home/runner/go/pkg/mod
key: go-mod
- name: Reformat code base
run: make fmt
- name: Stop if reformatted
run: git diff --exit-code
- name: Run linters
run: make lint
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Expand Up @@ -11,7 +11,7 @@ on:
types: [opened, reopened]

jobs:
tests:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
Expand All @@ -23,4 +23,4 @@ jobs:
path: /home/runner/go/pkg/mod
key: go-mod
- name: Run test suite
run: make tests
run: make test
5 changes: 0 additions & 5 deletions .goreleaser.yml
@@ -1,10 +1,5 @@
# Make sure to check the documentation at http://goreleaser.com

before:
hooks:
- go vet ./...
- go test --cover ./...

builds:
- env:
- CGO_ENABLED=0 # this is needed otherwise the Docker image build is faulty
Expand Down
14 changes: 11 additions & 3 deletions Makefile
@@ -1,14 +1,22 @@
.PHONY: all build clean dist fmt tests

all: clean fmt tests build
all: clean lint tests build

fmt:
@echo 'Reformat Go code ...'
go fmt ./...

tests:
vet:
@echo 'Examine Go code ...'
go vet ./...

lint: fmt vet
@echo 'Check for uncommitted changes ...'
git diff --exit-code

test:
@echo 'Run all tests ...'
go test ./...
go test --cover ./...

build:
@echo 'Build seiso binary ...'
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -247,7 +247,7 @@ make fmt

Run test suite:
```console
make tests
make test
```

Build seiso binary:
Expand Down

0 comments on commit de8b800

Please sign in to comment.