Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orphaned image deletion #11

Merged
merged 2 commits into from
Feb 13, 2020
Merged

Orphaned image deletion #11

merged 2 commits into from
Feb 13, 2020

Conversation

zugao
Copy link
Contributor

@zugao zugao commented Feb 10, 2020

Added several features:

  • orphan image cleaning
  • filter by regex (in orphan mode only)
  • delete images that are older than a specific date.
  • fixed some sort test cases
  • updated the unlimited value in limit flag from -1 to 0 and default from 100 to unlimited-

@zugao zugao requested a review from ccremer February 10, 2020 16:40
ccremer
ccremer suggested changes Feb 10, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cmd/imagestream.go Outdated Show resolved Hide resolved
cmd/imagestream.go Outdated Show resolved Hide resolved
cmd/imagestream.go Outdated Show resolved Hide resolved
pkg/cleanup/cleanup.go Outdated Show resolved Hide resolved
pkg/cleanup/cleanup.go Outdated Show resolved Hide resolved
pkg/cleanup/cleanup.go Outdated Show resolved Hide resolved
pkg/cleanup/cleanup.go Outdated Show resolved Hide resolved
cmd/imagestream.go Show resolved Hide resolved
@ccremer ccremer changed the title Oprhan management Orphaned image deletion Feb 10, 2020
ccremer
ccremer suggested changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

round 2

cmd/imagestream.go Show resolved Hide resolved
pkg/cleanup/cleanup.go Show resolved Hide resolved
@zugao zugao requested a review from ccremer February 11, 2020 13:15
@ccremer
Copy link
Contributor

ccremer commented Feb 11, 2020

I haven't run the code once. As I'm busy atm, maybe involve @srueg too?

@zugao zugao requested a review from srueg February 11, 2020 14:34
@zugao
Copy link
Contributor Author

zugao commented Feb 11, 2020

Added @srueg as a reviewer as well

srueg
srueg suggested changes Feb 11, 2020
View reviewed changes
cmd/imagestream.go Outdated Show resolved Hide resolved
pkg/cleanup/cleanup.go Outdated Show resolved Hide resolved
pkg/cleanup/cleanup.go Outdated Show resolved Hide resolved
cmd/imagestream.go Outdated Show resolved Hide resolved
cmd/imagestream.go Outdated Show resolved Hide resolved
pkg/cleanup/cleanup.go Show resolved Hide resolved
@zugao zugao requested a review from srueg February 11, 2020 15:42
@zugao
Copy link
Contributor Author

zugao commented Feb 11, 2020

It seems I fixed everything, who is the brave one to merge it @srueg, @ccremer ?

ccremer
ccremer approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@srueg srueg merged commit 504a38d into master Feb 13, 2020
@srueg srueg deleted the oprhan-management branch February 13, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srueg srueg srueg approved these changes

@ccremer ccremer ccremer approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zugao @ccremer @srueg