Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was looking why the command
seiso image history namespace/project --keep 0
wanted to remove our image stream which were running on our integration environment:The
cd3b3c7644b7ab1c1521d9b9d4c518543b5a51e7
tag is currently running so I was surprised it was a delete candidate.I had to add a log.info to explicitly shows which tags were found active.
With this, log, I've found that
cd3b3c7644b7ab1c1521d9b9d4c518543b5a51e7
tag wasn't found as active.Then, I continue to debug and found this error in the
helper.ResourceContains
: it looked only one resource, didn't find the image tag and return.This PRs fixes it to loop over all Resources up to find one matching.
The final result in my case is:
Unfortunately, I don't know Go and so I'm not be able to add / fix the unit tests.