Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #50

Merged
merged 2 commits into from Apr 20, 2021
Merged

Update dependencies #50

merged 2 commits into from Apr 20, 2021

Conversation

srueg
Copy link
Contributor

@srueg srueg commented Apr 19, 2021 •
edited

Summary

Update dependencies and project setup.
Copied from https://github.com/vshn/espejo

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update the documentation.
  • Update tests.
  • Link this PR to related issues.

@srueg srueg marked this pull request as ready for review April 19, 2021 12:56
ccremer
ccremer suggested changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing some required targets in the Makefile, e.g. docker-build is one of them

@srueg srueg merged commit f3c3252 into master Apr 20, 2021
@srueg srueg deleted the update-dependencies branch April 20, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccremer ccremer ccremer approved these changes

@zugao zugao Awaiting requested review from zugao

@anothertobi anothertobi Awaiting requested review from anothertobi

Assignees
No one assigned
Labels
dependency
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srueg @ccremer