Badges and tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srueg
approved these changes
Nov 28, 2019
|
I don't have merge rights on this repo. |
|
I have reworked the Docker build setup and removed multiarch support for Docker. Care to review again? |
bittner
reviewed
Nov 28, 2019
|  | ||
|  | ||
|  | ||
|
|
There was a problem hiding this comment.
I'd suggest to align that with how we did it on some of the other container repositories, e.g.
|
wait...pipeline will fail for master |
Integrate building and pushing into goreleaser instead
|
As discussed with @srueg , we will not do docker pushes on master branch anymore, only tags. As such, I have adapted the pipeline so that docker builds & pushes also happens with goreleaser |
Since Go is a compiled language, it does that implicitly during test/build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in internal ticket VT-1069, here are some badges and some sample unit tests