-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Badges and tests #6
Conversation
I don't have merge rights on this repo. |
I have reworked the Docker build setup and removed multiarch support for Docker. Care to review again? |
![](https://img.shields.io/docker/pulls/appuio/image-cleanup) | ||
![](https://img.shields.io/github/v/release/appuio/image-cleanup) | ||
![](https://img.shields.io/github/license/appuio/image-cleanup) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to align that with how we did it on some of the other container repositories, e.g.
wait...pipeline will fail for master |
Integrate building and pushing into goreleaser instead
As discussed with @srueg , we will not do docker pushes on master branch anymore, only tags. As such, I have adapted the pipeline so that docker builds & pushes also happens with goreleaser |
Since Go is a compiled language, it does that implicitly during test/build
As discussed in internal ticket VT-1069, here are some badges and some sample unit tests