Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight content type #30

Merged
merged 3 commits into from Aug 24, 2018
Merged

Highlight content type #30

merged 3 commits into from Aug 24, 2018

Conversation

mebagel
Copy link
Collaborator

@mebagel mebagel commented Aug 24, 2018

If creating a GitHub webook, the default content type changed to "application/x-www-form-urlencoded". Highlight to change it to "application/json"

@mebagel mebagel requested a review from bliemli August 24, 2018 11:13
@bliemli
Copy link
Member

bliemli commented Aug 24, 2018

Please also consider the fact that SSL verification does not have to be disabled anymore.

@bliemli
Copy link
Member

bliemli commented Aug 24, 2018

Please also apply the following patch:

diff --git a/labs/09_dockerbuild_webhook.md b/labs/09_dockerbuild_webhook.md
index e93183f..12585af 100644
--- a/labs/09_dockerbuild_webhook.md
+++ b/labs/09_dockerbuild_webhook.md
@@ -85,7 +85,7 @@ Klicken Sie auf Webhooks & services:
 Fügen Sie einen Webhook hinzu:
 ![Github Webhook](../images/lab_09_webhook_github3.png)
 
-Fügen Sie die entsprechende GitHub Webhook URL aus Ihrem OpenShift Projekt ein und "disablen" Sie die SSL verification. Auf der Lab Plattform verfügen wir nur über self-signed Zertifikate.
+Fügen Sie die entsprechende GitHub Webhook URL aus Ihrem OpenShift Projekt ein:
 ![Github Webhook](../images/lab_09_webhook_github4.png)
 
 Ab jetzt triggern alle Pushes auf Ihrem GitHub Repository einen Build und deployen anschliessend die Code-Änderungen direkt auf die OpenShift-Plattform.

@bliemli bliemli merged commit 76b6d0c into appuio:lab-3.9 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants