Write tests for S3 store #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 4, 2018
hauleth
force-pushed
the
test-s3-store
branch
2 times, most recently
from
8c9c5c9
to
57b0dea
Compare
This mocks S3 REST API via Bypass. In my humble opinion in this situation it is better choice than mocking ExAws directly as S3 REST API is less likely to change and we can test different situations independently (i.e. network outages) without digging to ExAws internals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mocks S3 REST API via Bypass. In my humble opinion in this
situation it is better choice than mocking ExAws directly as S3 REST API
is less likely to change and we can test different situations
independently (i.e. network outages) without digging to ExAws internals.