Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if mix is present before using Mix.env() #10

Closed
wants to merge 3 commits into from
Closed

Check if mix is present before using Mix.env() #10

wants to merge 3 commits into from

Conversation

mkaszubowski
Copy link
Contributor

No description provided.

sourcelevel-bot[bot]
sourcelevel-bot bot reviewed Oct 13, 2017
View reviewed changes
lib/mockery.ex Outdated
@@ -107,4 +107,8 @@ defmodule Mockery do

mod
end

defp mix_env() do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use parentheses when defining a function which has no arguments.

@coveralls
Copy link

coveralls commented Oct 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling bf0c896 on mkaszubowski:mix-prod into 4b6901a on appunite:master.

@coveralls
Copy link

coveralls commented Oct 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 5eb8b39 on mkaszubowski:mix-prod into 4b6901a on appunite:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5eb8b39 on mkaszubowski:mix-prod into 4b6901a on appunite:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5eb8b39 on mkaszubowski:mix-prod into 4b6901a on appunite:master.

@coveralls
Copy link

coveralls commented Oct 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling d3ddc05 on mkaszubowski:mix-prod into 4b6901a on appunite:master.

@sourcelevel-bot
Copy link

Ebert has finished reviewing this Pull Request and has found:

  • 7 possible new issues (including those that may have been commented here).

But beware that this branch is 28 commits behind the appunite:master branch, and a review of an up to date branch would produce more accurate results.

You can see more details about this review at https://ebertapp.io/github/appunite/mockery/pulls/10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcelevel-bot sourcelevel-bot[bot] sourcelevel-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkaszubowski @coveralls