Skip to content

Commit

Permalink
Update the readme and contributing files
Browse files Browse the repository at this point in the history
Some of the information was out-of-date and we now also link to the template-tag authoring format documentation to get people started faster.
  • Loading branch information
Windvis committed Oct 10, 2023
1 parent 4e9d878 commit c3bf1e5
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 15 deletions.
9 changes: 4 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

- `git clone <repository-url>`
- `cd ember-appuniversum`
- `npm install` (use npm 6 until we drop node 14 support)
- `npm install`

### Linting

Expand All @@ -37,13 +37,12 @@

### Running tests

- `ember test` – Runs the test suite on the current Ember version
- `ember test --server` – Runs the test suite in "watch mode"
- `ember try:each` – Runs the test suite against multiple Ember versions
- start the development server `npm run ember` and go to the `/tests` route
- `npm run test:ember` – Runs the test suite on the current Ember version

### Running the dummy application

- `npm start`
- Visit the storybook application at [http://localhost:6006](http://localhost:4200).
- Visit the storybook application at [http://localhost:6006](http://localhost:6006).

For more information on using ember-cli, visit [https://cli.emberjs.com/release/](https://cli.emberjs.com/release/).
31 changes: 21 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# @appuniversum/ember-appuniversum

Ember addon wrapping [the appuniversum components](https://appuniversum.github.io/ember-appuniversum/).
Ember addon that provides components for Flanders themed applications.

## Compatibility

Expand All @@ -11,38 +11,49 @@ Ember addon wrapping [the appuniversum components](https://appuniversum.github.i
## Installation

```
ember install @appuniversum/ember-appuniversum
npm install --save-dev @appuniversum/ember-appuniversum
```

## Usage

This ember addon wraps a CSS framework for Flanders government applications called appuniversum. It provides components that helps being complient with this framework in Ember apps.
This ember addon wraps a CSS framework for Flanders government applications called Appuniversum. It provides components that helps being compliant with this framework in Ember apps.

## Contributing

See the [Contributing](CONTRIBUTING.md) guide for details.

## Development

Local development:
### Running the local development setup

- Build the ember app: `npm run ember`
- Start the ember app: `npm run ember`
- Run the documentation site: `npm run storybook` (make sure the `npm run ember` command is finished)
- Generate the icons: `npm run icons`

Testing:
> We use the "template tag" (.gjs) format for component authoring which has been described in detail in the [RFC](https://github.com/emberjs/rfcs/blob/master/text/0779-first-class-component-templates.md).
> A summarized version can be found in the ember-template-imports library which also has some information about [how to setup your dev environment](https://github.com/ember-template-imports/ember-template-imports#editor-integrations) for a better experience.
- PR previews and testing is available on [Chromatic](https://www.chromatic.com/build?appId=61e5835e5fbce3003a653ee6)
### Testing:

Releases:
- the `/tests` route allows you to run the tests in your browser.
- Specific ember-try scenarios can be run if you want to debug them locally: `npx ember try:one scenario-name`. `--skip-cleanup` can be used to debug the scenario from the `/tests` route
- PR previews and testing is available on [Chromatic](https://www.chromatic.com/build?appId=61e5835e5fbce3003a653ee6)

- Release to npm: `npm run release`
### Testing changes in apps

Link to an ember project:
#### npm link

- In the addon: `npm link`
- In the your project: `npm link @appuniversum/ember-appuniversum`

#### yalc

[yalc](https://github.com/wclr/yalc) is a good alternative if the npm link setup doesn't work as expected.

### Releases:

Release to npm: `GITHUB_AUTH=your-token npm run release` and follow the prompts

## License

This project is licensed under the [MIT License](LICENSE.md).

0 comments on commit c3bf1e5

Please sign in to comment.