-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
behavior when clicking outside a modal #265
Comments
What's the use-case for this? Why do you want to keep the modal open in that scenario? |
@Windvis when user accidentally clicks outside the modal, modal is closed which is annoying. Feedback from the testers. |
@Dietr just double checking. Is disabling the backdrop clicking ok from a UX perspective? I think it raises some more questions:
I fear that it might be weird for users that some modals in a project allow it while others in the project don't but maybe that's something that should be user tested. Maybe this is a case where a modal wasn't the right pattern and using a different setup might be better? |
I'm not a fan of disabling escape or disabling the close when you click on the background for consistency reasons. A modal has a certain behavour that should be as expected. We could decide to remove the background click for all modals though. I'll do some research about the best practice for that. I think that a non-closable dialog or prompt window for accept/decline actions could also be useful but maybe better to create a new component for this? (see for example: https://www.lightningdesignsystem.com/components/prompt/) |
in bootstrap, static backdrop seems to be a thing: https://getbootstrap.com/docs/5.2/components/modal/#static-backdrop |
Did some more research on this. We should differentiate between a modal and a dialog/prompt component.
We can easily create a prompt component based on the modal. Regarding the click-outside issue. If user-testing confirms that this is a common issue in our products we can remove this on all modals. |
I think this was resolved by #411 |
instead of:
It would be nice if we could change that behavior like e.g :
The text was updated successfully, but these errors were encountered: