Deprecate the app/styles/* import paths
#444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
added
the
enhancement
These new paths are compatible with v2 addons so we can convert the addon without it being a breaking change in the future.
This pattern only works for v1 addons so it's a blocker for the v2 addon conversion. By deprecating the old paths we can convert Appuniversum to the v2 blueprint in the future.
Adding "node_modules" to the `includePath` option slows down rebuilds _a lot_ (x10). Adding only the appuniversum package also seems to work (without changing the import paths, strangely) without slowing down the build.
Windvis
force-pushed
the
chore/deprecate-app-style-import-paths
branch
from
21d7e69
to
57b0ebc
Compare
Windvis
added
the
Deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new top level import paths and deprecates the old ones that depend on ember-cli's app folder merging.
I didn't find a way to do this without duplicating the files, so we'll need to do some git trickery when removing the old files in the future so the git history is kept.
Closes #443