Add vote star filled icon #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lagartoverde
added
the
enhancement
|
It seems we also keep a list in the dummy app: https://github.com/appuniversum/ember-appuniversum/blob/master/tests/dummy/app/components/au-icon-list.js We should probably refactor that, but could you add it in there as well for now? |
|
Also, doesn't this imply that there should also be an "empty" vote star icon? 😄 |
Well, that is left as future work :P |
If that icon is already designed I would add it to this PR as well, just so we don't have to create multiple releases for icons 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added this icon provided by Saska as we need it on the CLBV app, would be great if this can be released quickly :)