Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vcpkg for VS2017 workers to fix annoying warning. #3549

Open
XVilka opened this issue Oct 21, 2020 · 4 comments
Open

Update Vcpkg for VS2017 workers to fix annoying warning. #3549

XVilka opened this issue Oct 21, 2020 · 4 comments

Comments

@XVilka
Copy link

XVilka commented Oct 21, 2020

Currently it spills this with Meson + MSBuild:

  Performing Custom Build Tools
  Vcpkg is unable to link because we cannot decide between Release and Debug libraries. Please define the property VcpkgConfiguration to be 'Release' or 'Debug' (currently 'release').

https://ci.appveyor.com/project/radareorg/radare2/builds/35867517/job/275idj44r4maytb1?fullLog=true#L547

See microsoft/vcpkg#3763 and microsoft/vcpkg#2790

There are many releases available since the fix landed in vcpkg: https://github.com/microsoft/vcpkg/releases
Probably one of them should fix the problem.

In fact, for some reason it also happens in VS2019 worker: https://ci.appveyor.com/project/radareorg/radare2/builds/35867517/job/xbmfrxmc80vr70fm?fullLog=true#L349

@FeodorFitsner
Copy link
Member

Have you tried building on Visual Studio 2019 image? It has the most recent vcpkg installed.

@XVilka
Copy link
Author

XVilka commented Oct 22, 2020

@FeodorFitsner yes, it happens on that image as well: https://ci.appveyor.com/project/radareorg/radare2/builds/35867517/job/xbmfrxmc80vr70fm?fullLog=true#L349

    # VS2019 64
    - builder: vs2019_64
      PYTHON: 'C:\\Python38-x64'
      INNO_SETUP: 'C:\\Program Files (x86)\\Inno Setup 6'
      APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
      BUILD_DIR: build
      RUN_TESTS: true

https://github.com/radareorg/radare2/blob/master/.appveyor.yml#L26

@FeodorFitsner
Copy link
Member

vcpkg has been updated on VS 2019 image. Let me know if your build works there.

@XVilka
Copy link
Author

XVilka commented Oct 29, 2020

@FeodorFitsner curiously it didn't solve the problem of the warning but also made builds slower: radareorg/radare2#17859 (compare build 8019 with build 8020)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants