Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove IP lookup for nonat, check for Get-NetIPAddress cmdlet #3692

Merged
merged 2 commits into from
Aug 23, 2021
Merged

remove IP lookup for nonat, check for Get-NetIPAddress cmdlet #3692

merged 2 commits into from
Aug 23, 2021

Conversation

GitMensch
Copy link
Contributor

@GitMensch GitMensch commented Jul 11, 2021 •
edited
Loading

fixes #3691

  • fixing by explicit check (better than stack-trace and in-line with Linux check)
  • only do IP lookup when relevant

@GitMensch GitMensch mentioned this pull request Jul 11, 2021
Closed
@GitMensch
Copy link
Contributor Author

GitMensch commented Aug 23, 2021 •
edited
Loading

@FeodorFitsner Can I suggest you merge this?

If notat isn't set it saves one unused IP lookup, and even if this is only for BYOC then it still keeps the flow a bit more clean.
I've just added an explicit check which fixes the original issue.

@GitMensch GitMensch changed the title remove IP lookup for nonat remove IP lookup for nonat, check for Get-NetIPAddress cmdlet Aug 23, 2021
@FeodorFitsner FeodorFitsner merged commit a6f7fdb into appveyor:master Aug 23, 2021
@GitMensch GitMensch deleted the patch-1 branch August 23, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RDP script does not work - ObjectNotFound: (Get-NetIPAddress:String) when executing enable-rdp.ps1
2 participants
@GitMensch @FeodorFitsner