🐛 Bug Report: getFlag aspect ratio / wrong rendering

[XeroxDev]

👟 Reproduction steps

I used the /v1/avatars/flags/ endpoint and got not expected results. See results below:

👍 Expected behavior

Return the right aspect ratio of the flag like in the files itself (https://github.com/appwrite/appwrite/blob/master/app/config/avatars/flags/de.png)

How to fix it: calculate the right (missing) width / height, especially because they're optional.

👎 Actual Behavior

/v1/avatars/flags/de

/v1/avatars/flags/de?height=25

/v1/avatars/flags/de?width=50

/v1/avatars/flags/de?width=200

🎲 Appwrite version

Version 0.13.x

💻 Operating system

Linux

🧱 Your Environment

I use nginx as a reverse proxy.

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct

[christyjacob4]

@XeroxDev thanks for raising this issue.
@Meldiron Please take a look at the image library

[Meldiron]

Issue resolved with PR mentioned above. (check it out, there are pictures 😮)

Let's keep this issue open until we get the PR merged and ready for release.

[eldadfux]

Actually this is the expected behavior. By default, the API crop the image and both default values for width and height are set to 100. To get the automatically calculate relative value, you just need to set 0 for one of the params.

[XeroxDev]

Actually this is the expected behavior. By default, the API crop the image and both default values for width and height are set to 100. To get the automatically calculate relative value, you just need to set 0 for one of the params.

Interesting, thanks. That works! But I'm curious, shouldn't this be the default behavior?

[eldadfux]

If we set both values to 0, you will get the original images size by default which in most cases is far from the optimized resolution for your app or website. By setting the default to 100x100 we make developers aware of this feature to better use it and have better performance.

[XeroxDev]

If we set both values to 0, you will get the original images size by default which in most cases is far from the optimized resolution for your app or website. By setting the default to 100x100 we make developers aware of this feature to better use it and have better performance.

Wouldn't it be better to just set the height to 100 as default and width to 0?

[eldadfux]

It will probably not matter as much, but for consistency with other endpoints, and for us to not assume what's better width vs height, I think leaving it as is should be fine.

[eldadfux]

That said, @Meldiron is updating the docs to make it more clear.

[XeroxDev]

Okay. That's a good idea.

[eldadfux]

This feature is now released and available as part of Appwrite 0.14. More on the new release here: #3240