Properly crop images in avatars API

[Meldiron]

What does this PR do?

Solves issue when resizing was not done properly if only one parameter was provided.

• Fix Initials
• Fix Flags
• Fix Credit Cards
• Fix Browsers
• Fix URL Image

Not only we support proper resizing now, we also return full resolution unless asked to downscale.

Test Plan

• Manual QA

(Yes, I tested all affected endpoints)

Related PRs and Issues

#3082

Have you read the Contributing Guidelines on issues?

Yes

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1202115796713529

[eldadfux]

Not sure about this.

1. this is a breaking change
2. default image will have 0x0 size
3. If this is the case, should we make both params required?

Could this be solved by just mentioning that providing the value 0 will keep the original width or height?

[Meldiron]

@eldadfux

1. Kind-of. Same code will still work, but instead of getting default size of 100x100, you will get source image at maximum resolution
2. Correct and that's fine, that means original resolutions will be provided

Documenting endpoints better would also be a valid solution, yes.

[eldadfux]

I think I would prefer to force the 100x100 resolution for preview images, to make devs aware of this instead of loading images in full resolution by default where most of the time it's far from optimized.

[Meldiron]

@eldadfux PR updated to only address documentation changes. It also includes fox when QR code size 0x0 was allowed, resulting in a server error.

[eldadfux]

One minor comment.

[eldadfux]

Approved, once conflict is resolved we can merge.