Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide/Show secret keys and passwords inside the dashboard #535

Closed
eldadfux opened this issue Sep 12, 2020 · 21 comments
Closed

Hide/Show secret keys and passwords inside the dashboard #535

eldadfux opened this issue Sep 12, 2020 · 21 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags! help wanted Extra attention is needed

Comments

@eldadfux
Copy link
Member

Currently all secret keys or http password used for OAuth apps, webhooks and background tasks are visible in the Appwrite console by default. This is not the best practice when taking screenshots, video recording or sharing your screen with other people.

We need to create a new UI components that will add a small show/hide button above relevant input fields and will toggle them between and when the default option should be password view.

image

@eldadfux eldadfux added enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags! help wanted Extra attention is needed javascript labels Sep 12, 2020
@gagandeepp
Copy link

can you assign this issue to me?

@eldadfux
Copy link
Member Author

@gagandeepp sure. please reach out on Discord if you need any help. Note that we're using vanilla JS for most of our UI, and please avoid any un-required dependencies. More info is available on Appwrite's contribution guide.

@mitchell-frost
Copy link

If this issue is still open, can I take it up?

@AbhishekTiwari07
Copy link

@eldadfux can i work on this issue?

@Aarush-Goyal
Copy link

If the issue is open can I work on it?

@SubashMuruganDev
Copy link

is this issue still open if so can i work on it ?

@gagandeepp gagandeepp removed their assignment Oct 27, 2020
@Glide7
Copy link
Contributor

Glide7 commented Dec 15, 2020

Hey @SubashMuruganDev , do you want to take it?

@Glide7 Glide7 added the dwoc label Dec 15, 2020
@Aarush-Goyal
Copy link

If this issue is still open then I would like to take it

@Glide7
Copy link
Contributor

Glide7 commented Dec 19, 2020

Sounds good @Aarush-Goyal - i've assigned you on it!
Feel free to ask for help if needed!

@Aarush-Goyal
Copy link

Cool

@Aarush-Goyal
Copy link

@Glide7 I didn't knew the code was in PHP and I haven't worked with it pls unassign the issue from me.
Sorry for the inconvenience

@Aarush-Goyal Aarush-Goyal removed their assignment Dec 20, 2020
@kodumbeats
Copy link
Contributor

I'd like to work on this one, if you please.

@Glide7
Copy link
Contributor

Glide7 commented Dec 20, 2020

That's ok @Aarush-Goyal - thanks for trying to help!

@kodumbeats sure! assigned you!

@kodumbeats
Copy link
Contributor

Just to clarify - should this feature be developed from master or 0.7.x? CONTRIBUTING.md says master, but I've seen other issues specify the starting branch.

@eldadfux
Copy link
Member Author

@kodumbeats you should use the 0.7.x branch 👍🏻

@Akshit42-hue
Copy link

@eldadfux @Glide7 Can i work on this issue

@Glide7
Copy link
Contributor

Glide7 commented Dec 27, 2020

Hey @Akshit42-hue - it's currently being worked on by @kodumbeats . we'll let you know if something changes! thanks for helping!

@Akshit42-hue
Copy link

@Glide7 ok

@kodumbeats
Copy link
Contributor

Should we leave this issue open for potential style changes? Or is #791 sufficient to close?

@Glide7
Copy link
Contributor

Glide7 commented Jan 3, 2021

@eldadfux What do you think?

@eldadfux
Copy link
Member Author

@kodumbeats awesome work, this feature is now available on Appwrite 0.7 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags! help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

9 participants