🐛 Bug Report: The Msg91 OTP isn't working after the 1.5 upgrade

[rohankm]

👟 Reproduction steps

Hi,
I have set it up according to the docs https://appwrite.io/docs/advanced/self-hosting/sms
the OTP for login was working before the upgrade to 1.5

here are the appwrite-worker-messaging logs

Warning: Undefined array key "templateId" in /usr/src/code/src/Appwrite/Platform/Workers/Messaging.php on line 461
[Job] (65f19b7b27cfc0.65895609) failed to run.
[Job] (65f19b7b27cfc0.65895609) Utopia\Messaging\Adapter\SMS\Msg91::__construct(): Argument #3 ($templateId) must be of type string, null given, called in /usr/src/code/src/Appwrite/Platform/Workers/Messaging.php on line 461
[Error] Type: TypeError
[Error] Message: Utopia\Messaging\Adapter\SMS\Msg91::__construct(): Argument #3 ($templateId) must be of type string, null given, called in /usr/src/code/src/Appwrite/Platform/Workers/Messaging.php on line 461
[Error] File: /usr/src/code/vendor/utopia-php/messaging/src/Utopia/Messaging/Adapter/SMS/Msg91.php
[Error] Line: 21

👍 Expected behavior

it should send the otp

👎 Actual Behavior

Warning: Undefined array key "templateId" in /usr/src/code/src/Appwrite/Platform/Workers/Messaging.php on line 461
[Job] (65f19b7b27cfc0.65895609) failed to run.
[Job] (65f19b7b27cfc0.65895609) Utopia\Messaging\Adapter\SMS\Msg91::__construct(): Argument #3 ($templateId) must be of type string, null given, called in /usr/src/code/src/Appwrite/Platform/Workers/Messaging.php on line 461
[Error] Type: TypeError
[Error] Message: Utopia\Messaging\Adapter\SMS\Msg91::__construct(): Argument #3 ($templateId) must be of type string, null given, called in /usr/src/code/src/Appwrite/Platform/Workers/Messaging.php on line 461
[Error] File: /usr/src/code/vendor/utopia-php/messaging/src/Utopia/Messaging/Adapter/SMS/Msg91.php
[Error] Line: 21

🎲 Appwrite version

Appwrite Cloud

💻 Operating system

Linux

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct

[stnguyen90]

@rohankm, thanks for creating this! 🙏🏼 Looks like we need to:

1. extract the templateId from the env var and set it here

MSG91 in the Messaging Providers is also broken. For that, we'll need to:

1. Update the Create MSG91 endpoint to:
   • accept templateId as a param
   • add templateId to credentials
   • remove the from param
2. Update the Update MSG91 endpoint to:
   • accept templateId as a param
   • add templateId to credentials
   • remove the from param
3. Update the Console

[rohankm]

@stnguyen90 temporary i manually set the keys here

appwrite/src/Appwrite/Platform/Workers/Messaging.php

Line 461 in 536c67f

'msg91' => new Msg91($credentials['senderId'], $credentials['authKey'], $credentials['templateId']),

I logged the messages being sent and it's like this 596853 is your myProject verification code.

for Msg91 especially in India there are specific variables set which cannot be exceeded certain length

here is the error message from Msg91

DLT Template variable exceeded max length

[rohankm]

as a workaround for this i had to modify this line of code

appwrite/app/controllers/api/account.php

Line 2301 in f7e6d51

$message = $message->setParam('{{token}}', $messageContent);

$message = $message->setParam('{{token}}', $secret);

[stnguyen90]

DLT Template variable exceeded max length

Thanks for raising this! Looks like their FAQ says:

Q. What is the character limit in Variable {#var#} while sending SMS?

The actual value of the variable while sending an SMS will be maximum 30 characters, for English and Unicode both.