🐛 Bug Report: 429 Too Many Requests at high upload speeds

[WuGGu]

👟 Reproduction steps

Upload big file like 1GB. Use a Internet connection with 200Mbit Upload.

👍 Expected behavior

Should just upload quicker to the storage.

👎 Actual Behavior

Returns 429 after a view seconds because of Too Many Requests in under 60 seconds.

🎲 Appwrite version

Version 1.5.x

💻 Operating system

Linux

🧱 Your Environment

Hetzner Machine with Rocky Linux and Docker.

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct

[stnguyen90]

@WuGGu, thanks for creating this issue! 🙏🏼 Would you please share the exact full error? Request and response headers would also be helpful.

[WuGGu]

I'll be back in the office on Tuesday due to the Easter vacation and will reproduce it. 😊

[WuGGu]

@stnguyen90
I hope this helps =) In my company we have 1Gbit Up and Downstream.

{
    "message": "Rate limit for the current endpoint has been exceeded. Please try again after some time.",
    "code": 429,
    "type": "general_rate_limit_exceeded",
    "version": "1.5.4"
}

payload:

fileId: unique()
file: (binary)
permissions[]: read("team:65fd90808a4607e5755e")
permissions[]: write("team:65fd90808a4607e5755e/owner")

[stnguyen90]

@WuGGu, thanks for this! Also, what are you using to create the file? If you're using one of our SDKs, would you please provide the version?

[stnguyen90]

Ahh wait I think I found the problem. Looks like we made a fix in #7154, but there was a regression and abuse key is missing the chunkId:

appwrite/app/controllers/api/storage.php

Line 342 in 2993537

->label('abuse-key', 'ip:{ip},method:{method},url:{url},userId:{userId}')

Compared to 1.4.x:

appwrite/app/controllers/api/storage.php

Line 342 in 5cfaee4

->label('abuse-key', 'ip:{ip},method:{method},url:{url},userId:{userId},chunkId:{chunkId}')