Feat stateless webhooks worker #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TorstenDittmann
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Drops all DB related stuff from the webhooks worker and just pass the relevant data from the API point where we trigger the task for the worker?
The worker is only accessing the db to fetch the project's webhooks list which is already available to us in the relevant API scope. This change will increase the size of the task payload but will reduce database queries, improve speed, and make the webhooks worker completely independent.
Test Plan
Leverage e2e tests
Related PRs and Issues
N/A
Have you read the Contributing Guidelines on issues?
Yes