Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbos2/appwrite/feat-1738-croatian-translations #1825

Conversation

mbos2
Copy link
Contributor

@mbos2 mbos2 commented Oct 1, 2021

What does this PR do?

This PR includes locale translations for Croatian language

Test Plan

  • Cloned my forked appwrite repository
  • Added translations per instructions of #1738 issue
  • In my local forked appwrite folder I ran this command: docker-compose up -d --build - To pick up changes I made
  • I tested translations in Postman per these instruction: https://github.com/appwrite/appwrite/blob/master/docs/tutorials/add-translations.md#4-test-the-translations
    • Made GET requests: http://localhost/v1/locale/countries/eu and http://localhost/v1/locale/countries/eu
    • Added Header: X-Appwrite-Project: projectID
    • Added Header: X-Appwrite-Locale: hr
  • Ran postman request and it returned hr translations

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

This PR resolves this issue: #1738

Have you read the Contributing Guidelines on issues?

Yes

Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The accuracy of these would have to verified by someone who can speak Croatian 😅

@christyjacob4 christyjacob4 added the hacktoberfest-accepted Accepted for Hacktoberfest, will be merged later label Oct 4, 2021
@christyjacob4 christyjacob4 merged commit 011df42 into appwrite:master Oct 5, 2021
@christyjacob4
Copy link
Member

THANK YOU so much! All changes merged 🥳
Please reach out to me on our Discord server if you would like to claim your Appwrite swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted for Hacktoberfest, will be merged later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants