Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locales):Add Luxembourgish(lb) translation #1857

Merged
merged 1 commit into from Oct 6, 2021
Merged

feat(locales):Add Luxembourgish(lb) translation #1857

merged 1 commit into from Oct 6, 2021

Conversation

OscarRG
Copy link
Contributor

@OscarRG OscarRG commented Oct 3, 2021

What does this PR do?

Added translation for Luxembourgish by:

  • Generate translations for Luxembourgish in app/config/locale/translations/lb.json
  • The file app/init.php has been modified to include the translation json file.
  • The value lb has been assigned to the Luxembourgish language in the app/config/locale/codes.php file.
  • Test the translations

Test Plan

Simple translations have been added in the JSON. The language is added in codes.php and init.php and loads on hitting the URL with X-Appwrite-Locale header.

Related PRs and Issues

Issue #1747

Have you read the Contributing Guidelines on issues?

Yes.

Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description according to the PR template we provided

@christyjacob4 christyjacob4 merged commit 856c695 into appwrite:master Oct 6, 2021
@christyjacob4
Copy link
Member

THANK YOU so much! All changes merged 🥳
Please reach out to me on our Discord server if you would like to claim your Appwrite swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants