Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nynorsk Norwegian translation #2019

Merged
merged 2 commits into from Oct 12, 2021
Merged

Conversation

NeonSpork
Copy link
Contributor

@NeonSpork NeonSpork commented Oct 6, 2021

What does this PR do?

This PR does two things:
1 - Adds Nynorsk Norwegian translation (created nn.json, updated codes.php and init.php to reflect the addition of Nynorsk Norwegian as an option)
2 - Fixes a couple small errors in the preexisting Norwegian bokmål (no.json file) translation that were overlooked in an earlier PR (#1871).

Test Plan

Ran appwrite, followed the steps in the translation tutorial to slam out a GET request with Insomnia and got a cool 200 OK response.

Related PRs and Issues

This resolves issue #1756, and fixes typos from PR #1871.

Have you read the Contributing Guidelines on issues?

✔️ Yes I have!

"e-postadresse" should be one word,
misspelled "sendt"
@NeonSpork NeonSpork marked this pull request as ready for review October 6, 2021 21:54
Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to check if both no.php and nn.php have been loaded in `init.php as you can see in the issue description

@NeonSpork
Copy link
Contributor Author

You also need to check if both no.php and nn.php have been loaded in `init.php as you can see in the issue description

Yeah i added line 302 in init.php right above the preexisting no.json line to add nn.json since it was new. Was there somewhere else I was supposed to add that as well?

@christyjacob4 christyjacob4 added the hacktoberfest-accepted Accepted for Hacktoberfest, will be merged later label Oct 12, 2021
@christyjacob4 christyjacob4 merged commit 7650676 into appwrite:master Oct 12, 2021
@christyjacob4
Copy link
Member

THANK YOU so much! All changes merged 🥳
Please reach out to me on our Discord server if you would like to claim your Appwrite swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted for Hacktoberfest, will be merged later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants