Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mime types #2239

Merged
merged 3 commits into from Oct 17, 2021
Merged

Added mime types #2239

merged 3 commits into from Oct 17, 2021

Conversation

eldadfux
Copy link
Member

What does this PR do?

Allow new audio mime-types for viewing audio files on browsers.

Test Plan

Using existing tests

Related PRs and Issues

Fixes: #2233

Have you read the Contributing Guidelines on issues?

Yes

Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small adjustments.

app/config/storage/mimes.php Outdated Show resolved Hide resolved
app/config/storage/mimes.php Outdated Show resolved Hide resolved
eldadfux and others added 2 commits October 17, 2021 12:22
Co-authored-by: Damodar Lohani <lohanidamodar@users.noreply.github.com>
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldadfux eldadfux merged commit 1ea741e into master Oct 17, 2021
@TorstenDittmann TorstenDittmann deleted the fix-allow-audio-mime-types branch October 18, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Audio files are returned as text/plain in view mode
3 participants