New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a DNS warning during install #2450
Add a DNS warning during install #2450
Conversation
@PineappleIOnic can you attach a gif/video of the setup process? |
@eldadfux I have added a GIF, sorry for the low quality. I'm not sure why it's so compressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one tiny suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address Matej's comment and we can merge 👍
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
I've addressed the comment, We are ready to merge! 🥳 |
What does this PR do?
This PR will add a warning to the install dialogue if the domain is not 'localhost' reminding the user to set their DNS Records to point to their appwrite server.
Have you read the Contributing Guidelines on issues?
Yes, I have.