Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a DNS warning during install #2450

Merged
merged 5 commits into from Jul 15, 2022

Conversation

PineappleIOnic
Copy link
Member

@PineappleIOnic PineappleIOnic commented Nov 30, 2021

What does this PR do?

This PR will add a warning to the install dialogue if the domain is not 'localhost' reminding the user to set their DNS Records to point to their appwrite server.

Screenshot_2021-12-01_at_2 42 34_AM

Image from Gyazo

Have you read the Contributing Guidelines on issues?

Yes, I have.

@eldadfux
Copy link
Member

@PineappleIOnic can you attach a gif/video of the setup process?

@PineappleIOnic
Copy link
Member Author

@eldadfux I have added a GIF, sorry for the low quality. I'm not sure why it's so compressed.

@PineappleIOnic
Copy link
Member Author

@christyjacob4

Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one tiny suggestion.

app/tasks/install.php Outdated Show resolved Hide resolved
Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Matej's comment and we can merge 👍

Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
@PineappleIOnic
Copy link
Member Author

Please address Matej's comment and we can merge 👍

I've addressed the comment, We are ready to merge! 🥳

@christyjacob4 christyjacob4 merged commit 88a7712 into appwrite:master Jul 15, 2022
@stnguyen90 stnguyen90 added this to the 0.15.3 milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants