Feat: Wildcard hostname #3124
Merged
Feat: Wildcard hostname #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldadfux
reviewed
Apr 23, 2022
| <input name="hostname" type="text" class="margin-bottom" autocomplete="off" placeholder="localhost" required> | ||
| <label for="hostname">Hostname <span class="tooltip large" data-tooltip="The hostname that your website will use to interact with the <?php echo APP_NAME; ?> APIs in production or development environments. No protocol or port number required."><i class="icon-question"></i></span></label> | ||
| <input name="hostname" type="text" class="margin-bottom" autocomplete="off" placeholder="yourapp.com" required> | ||
| <div class="text-fade text-size-xs margin-top-negative-small margin-bottom">You can use * to allow wildcard hostnames or subdomains.</div> |
There was a problem hiding this comment.
In the future, it might be cool to add small buttons to allow to quickly add *.vercel.app or *.netlify.app
There was a problem hiding this comment.
Aaand *.*.gitpod.io probably
eldadfux
reviewed
Apr 23, 2022
TorstenDittmann
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
*.vercel.allor*.*.gitpod.ioor even simply*hostnamesTest Plan
CleanShot.2022-04-20.at.11.36.53.mp4
(I was able to create and read an anonymous session from
https://8080-meldiron-almostredditpla-1cocjbj09gp.ws-eu34xl.gitpod.io/index2.htmlwith the hostname was*.*.gitpod.ioor*or*.*.gitpod.*)Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes