Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: installation overriding default env variables #3241

Merged
merged 1 commit into from May 18, 2022
Merged

fix: installation overriding default env variables #3241

merged 1 commit into from May 18, 2022

Conversation

TorstenDittmann
Copy link
Contributor

What does this PR do?

  • when a variable was missing in .env - we override its default with an empty value instead of the default value from the config

Test Plan

  • manually tested

Have you read the Contributing Guidelines on issues?

✅

@TorstenDittmann TorstenDittmann merged commit 0390ec4 into master May 18, 2022
@TorstenDittmann TorstenDittmann deleted the fix-installation-env-defaults branch May 18, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TorstenDittmann @Meldiron