Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update success, loading, and error message for add team member #3296

Merged

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented May 27, 2022

What does this PR do?

Remove text indicating invitations since no emails are sent when adding a user via the Admin console.

Test Plan

Manually tested:

Loading Toast

Loading

Success Toast

Success

Error Toast

Error

Related PRs and Issues

Closes: #2955

Have you read the Contributing Guidelines on issues?

Yes

Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Remove text indicating invitations since no emails are sent when adding
a user via the Admin console.
@stnguyen90 stnguyen90 force-pushed the fix-2955-add-team-member-toast branch from b06ee0d to 4a87e73 Compare June 1, 2022 05:00
@stnguyen90
Copy link
Contributor Author

Rebased to fix checks

@TorstenDittmann TorstenDittmann merged commit 3d297e8 into appwrite:master Jun 1, 2022
@stnguyen90 stnguyen90 deleted the fix-2955-add-team-member-toast branch June 2, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Adding a team member says a verification email is sent but it's not
3 participants