Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database layer #3338

Merged
merged 81 commits into from Jun 22, 2022
Merged

Database layer #3338

merged 81 commits into from Jun 22, 2022

Conversation

lohanidamodar
Copy link
Member

What does this PR do?

  • Adds database layer to the database service above collection

Test Plan

  • Relevant tests are added

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

YES

@lohanidamodar lohanidamodar marked this pull request as draft June 5, 2022 06:46
@lohanidamodar lohanidamodar changed the base branch from master to 0.15.x June 5, 2022 06:48
@lohanidamodar lohanidamodar marked this pull request as ready for review June 21, 2022 03:40
@lohanidamodar
Copy link
Member Author

@gewenyu99 Waiting for documentation changes, rest should be done!

@lohanidamodar lohanidamodar requested review from Meldiron and fogelito and removed request for fogelito June 21, 2022 07:54
@lohanidamodar
Copy link
Member Author

@TorstenDittmann oh, wow. This was my best huge PR till now. Thanks 🙏🏻

@Meldiron
Copy link
Contributor

@lohanidamodar Didn't review yet, wanted to play around first. I made a project, database, and attribute (string 255, required). It is stuck at processing, tho there are no errors in the worker. Can you please try to reproduce?

Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but was really hard to review. I will try to review it again tomorrow with new set of eyes 👀

Either way, we will need to heavily test this before release.

@lohanidamodar
Copy link
Member Author

@lohanidamodar Didn't review yet, wanted to play around first. I made a project, database, and attribute (string 255, required). It is stuck at processing, tho there are no errors in the worker. Can you please try to reproduce?

May be something to do with cache or anything? I've not been able to reproduce

@TorstenDittmann TorstenDittmann merged commit 8f14f5a into 0.15.x Jun 22, 2022
@TorstenDittmann TorstenDittmann deleted the feat-database-layer branch June 22, 2022 10:51
gewenyu99 pushed a commit that referenced this pull request Jun 22, 2022
* database response model

* database collection config

* new database scopes

* database service update

* database execption codes

* remove read write permission from database model

* updating tests and fixing some bugs

* server side tests are now passing

* databases api

* tests for database endpoint

* composer update

* fix error

* formatting

* formatting fixes

* get database test

* more updates to events and usage

* more usage updates

* fix delete type

* fix test

* delete database

* more fixes

* databaseId in attributes and indexes

* more fixes

* fix issues

* fix index subquery

* fix console scope and index query

* updating tests as required

* fix phpcs errors and warnings

* updates to review suggestions

* UI progress

* ui updates and cleaning up

* fix type

* rework database events

* update tests

* update types

* event generation fixed

* events config updated

* updating context to support multiple

* realtime updates

* fix ids

* update context

* validator updates

* fix naming conflict

* fix tests

* fix lint errors

* fix wprler and realtime tests

* fix webhooks test

* fix event validator and other tests

* formatting fixes

* removing leftover var_dumps

* remove leftover comment

* update usage params

* usage metrics updates

* update database usage

* fix usage

* specs update

* updates to usage

* fix UI and usage

* fix lints

* internal id fixes

* fixes for internal Id

* renaming services and related files

* rename tests

* rename doc link

* rename readme

* fix test name

* tests: fixes for 0.15.x sync

Co-authored-by: Torsten Dittmann <torsten.dittmann@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants