Allows to update permissions without payload

[gepd]

What does this PR do?

Currently, to update the permission of a document, you also have to update some kind of data, or at least pass some kind of data.

This does not work:

await database.updateDocument(listCollection, list, {}, [`user:${user.$id}`]);

So to update permissions we have to pass some data, even if the data is the same as the current one:

await database.updateDocument(listCollection, list, {name: "test"}, [`user:${user.$id}`]);

This change will allow to send an empty payload, but empty payload and read/write permission will keep throwing an error

await database.updateDocument(listCollection, list, {}, [], []);

Test Plan

No new test

Related PRs and Issues

#2850

Have you read the Contributing Guidelines on issues?

yes

[gepd]

The failing test doesn't seems to be related with my changes

[TorstenDittmann]

Restarted the tests 👍🏻

I think it would make sense to make the data param optional. Otherwise it would be required but optional 🙂

[gepd]

@TorstenDittmann good catch I totally forgot about that, I'm not good at types in PHP, but reading the manual, that should be the way to make it optional

let me know if that is enough 😀

[TorstenDittmann]

Utopia has all those ->param before the callback. If the last argument is true, the parameter of the rest API is marked as optional 😉

[gepd]

@TorstenDittmann I think I got it, Is everyting good now?

[gepd]

I need help
After checking the test I realized there is something else looking for the document structure

I'm getting error 400 which I believe comes from here: https://github.com/gepd/appwrite/blob/feat-empty-payload/app/controllers/api/database.php#L1943

I'm not sure but, is this related to utopia php?

Seems like here is looking for a specific structure: https://github.com/utopia-php/database/blob/main/src/Database/Database.php#L1169-L1173

@Meldiron @TorstenDittmann

[gepd]

I have finally fixed, I have updated the test, I think not deleting the collection was causing problems

@Meldiron @TorstenDittmann

[Meldiron]

Looks good to me