Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unnecessary execution delays #3348

Merged
merged 2 commits into from Jun 9, 2022
Merged

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Jun 7, 2022

What does this PR do?

Prevents unnecessary run of sleep(2) when executing a function for the first time (without runtime ready). Affects both async=true/false, but only really visible with async=false.

Test Plan

  • Manual QA. Without this PR, I first received realtime update, then 1 second delay, then execution response. With this PR, they both come in at the same time.

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes ✅

@TorstenDittmann
Copy link
Contributor

Linter is failing 🙂

@Meldiron
Copy link
Contributor Author

Meldiron commented Jun 8, 2022

Linter is failing 🙂

Wow that's cool! Fixed.

@TorstenDittmann TorstenDittmann merged commit a9a00d7 into master Jun 9, 2022
@TorstenDittmann TorstenDittmann deleted the fix-first-execution-delay branch June 9, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants