Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook signature #3351

Merged
merged 8 commits into from Jun 8, 2022
Merged

webhook signature #3351

merged 8 commits into from Jun 8, 2022

Conversation

shimonewman
Copy link
Contributor

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

app/controllers/api/projects.php Outdated Show resolved Hide resolved
app/workers/webhooks.php Outdated Show resolved Hide resolved
tests/e2e/Services/Webhooks/WebhooksBase.php Outdated Show resolved Hide resolved
src/Appwrite/Utopia/Response/Model/Webhook.php Outdated Show resolved Hide resolved
Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just 2 tiny comments and I think that's it.

To fix the linter tests, you can run the following:

./vendor/bin/phpcbf

This will run the formatter according to our rules 👍🏻

Reference: https://github.com/appwrite/appwrite/blob/master/CONTRIBUTING.md#code-maintenance

src/Appwrite/Utopia/Response/Model/Webhook.php Outdated Show resolved Hide resolved
tests/e2e/Services/Webhooks/WebhooksBase.php Outdated Show resolved Hide resolved
shimonewman and others added 3 commits June 8, 2022 11:03
Co-authored-by: Torsten Dittmann <torsten.dittmann@googlemail.com>
Co-authored-by: Torsten Dittmann <torsten.dittmann@googlemail.com>
@TorstenDittmann TorstenDittmann merged commit 7b32311 into master Jun 8, 2022
@TorstenDittmann TorstenDittmann deleted the feat-webhook-signature branch June 8, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants