Feat Internal Runtime State #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meldiron
reviewed
Jun 9, 2022
Meldiron
approved these changes
Jun 15, 2022
christyjacob4
requested changes
Jun 19, 2022
There was a problem hiding this comment.
@PineappleIOnic This looks fine, I have some concerns over how it will behave with the retry logic that we already have in the Executor class...
Let's discuss tmro
Co-authored-by: Christy Jacob <christyjacob4@gmail.com>
This was referenced Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR re-implements runtime state into the executor allowing us to delay executions while a runtime is being launched, previously if an execution took place while a runtime was still launching it would fall through and result in an error. This PR remedies that.
Test Plan
No tests have been changed,
Have you read the Contributing Guidelines on issues?
Yes, I have