Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: account sessions for emails #3377

Merged
merged 3 commits into from
Jun 14, 2022
Merged

feat: account sessions for emails #3377

merged 3 commits into from
Jun 14, 2022

Conversation

TorstenDittmann
Copy link
Contributor

What does this PR do?

  • makes email not the default session creation anymore
  • adds POST:/v1/account/sessions/email

Test Plan

  • adapted all tests

Related PRs and Issues

#3357

Have you read the Contributing Guidelines on issues?

✅

eldadfux
eldadfux reviewed Jun 14, 2022
View reviewed changes
Copy link
Member

@eldadfux eldadfux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to update the console SDK and the console login window.

@TorstenDittmann TorstenDittmann merged commit a5e76d5 into feat-phone-authentication Jun 14, 2022
@TorstenDittmann TorstenDittmann deleted the feat-account-sessions-email branch June 14, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldadfux eldadfux eldadfux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TorstenDittmann @eldadfux