Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migration of attributes and indexes #3568

Merged
merged 2 commits into from Jul 22, 2022
Merged

fix: migration of attributes and indexes #3568

merged 2 commits into from Jul 22, 2022

Conversation

TorstenDittmann
Copy link
Contributor

@TorstenDittmann TorstenDittmann commented Jul 20, 2022 •
edited

What does this PR do?

  • fixes migration of attributes and indexes
  • both where not completely migrated due to re-creation of the document invalidating the cursor pagination

Test Plan

  • manually

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

✅

stnguyen90
stnguyen90 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I ran the migration and all attributes migrated:

Migrating Collection attributes:
100 / 101
101 / 101

Screenshot of 101st attribute available:

image

@TorstenDittmann TorstenDittmann merged commit e28ebcb into 0.15.x Jul 22, 2022
@TorstenDittmann TorstenDittmann deleted the fix-migration-attributes-indexes branch July 22, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TorstenDittmann @stnguyen90