Fix schedule loop triggering #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also did QA from CLI to ensure the specific use case is addressed.
|
TorstenDittmann
approved these changes
Sep 30, 2022
|
馃槏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If you set schedule in
createFunction, the schedule loop is never started. This occurs in Appwrite CLI. This PR solves it.Also, this PR makes it so
updateFunctionforcefully re-triggers schedule loop. Old loop will be stopped, so no double executions. This is useful, for instance, when you clean your Redis instance and loop is gone. By clicking "Update" on function settings you can easily re-trigger the loop.Test Plan
Manual QA for all edge cases I can think of:
Related PRs and Issues
x
Have you read the Contributing Guidelines on issues?
Yes 馃槆