New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed: wrong error message show on adding duplicate number to a user #4292
fixed: wrong error message show on adding duplicate number to a user #4292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akshay-Rana-Gujjar Thanks for the PR! 🤯 Would you be able to add a test case for this in tests/e2e/Services/Users/UsersBase.php?
Okay sure |
hi @stnguyen90, I have added the test cases as requested please have a look. I have marked added test cases with red underline for your reference. Let me know if there is anything required from my side, I will be happy to do that. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! 🤩 Just one more test please?
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |
What does this PR do?
Show correct toast or message when adding a duplicate phone number to a user.
Test Plan
Try to add duplicate phone number to different user to see the correct message.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes