-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly handle =
in .env
#4341
Conversation
@megatank58 Thanks for your PR! 🙏 To be fair during Hacktoberfest, we are only allowing the assignee to complete PRs for issues where we only need 1 submission. Please comment on the issue with your interest and we will assign the issue in the order received. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please add a test case for this?
I've added the tests, do let me know if something is wrong. |
Thank you so much for the PR 🤩. We're adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@TorstenDittmann, what do you think? |
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |
What does this PR do?
This PR adds the limit argument to explode method to correctly handle
=
in .env filesTest Plan
The code has been manually ran and tested against test case.
Related PRs and Issues
Closes #4294
Have you read the Contributing Guidelines on issues?
Yes