Fix User not found exception #4506
Conversation
There was a problem hiding this comment.
@karniv00l, thanks for catching this! Would you also be able to add a test case for this?
|
@stnguyen90 I've added missing test cases |
karniv00l
force-pushed
the
user-not-found-exception
branch
2 times, most recently
from
a28efb8
to
2e60508
Compare
karniv00l
force-pushed
the
user-not-found-exception
branch
from
2e60508
to
b65a8c8
Compare
|
@stnguyen90 not sure why tests failed, should we try again? |
There was a problem hiding this comment.
@karniv00l Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!
stnguyen90
added
the
hacktoberfest-accepted
|
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |
What does this PR do?
Currently, there's a bug with the way User not found exception is created. This PR fixes it.
Test Plan
You can see on the screenshot that
phpstanrecognizes it right away, however ideally there should be also a test case for thisifstatement. I'm not very familiar with the codebase, If anyone could point me to the appropriate test location, I could do it.Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you added your change to the Changelog?
(The CHANGES.md file tracks all the changes that make it to the
mainbranch. Add your change to this file in the following format)Have you read the Contributing Guidelines on issues?
yes