Feat redis sync #4540
Closed
Feat redis sync #4540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shimonewman
commented
Oct 20, 2022
•
shimonewman
commented
- Cache re-invoking issue
…-sync � Conflicts: � composer.lock
eldadfux
requested changes
Oct 23, 2022
…to feat-redis-sync � Conflicts: � app/init.php � app/preload.php � composer.json � composer.lock
eldadfux
requested changes
Oct 31, 2022
| @@ -0,0 +1,28 @@ | |||
| <?php | |||
|
|
|||
| return [ | |||
There was a problem hiding this comment.
This should be updated before merging. No need for default region.
| 'syncs' => [ | ||
| 'key' => 'edge', | ||
| 'name' => 'edge', | ||
| 'subtitle' => 'Appwrite\'s cache edge sync Endpoint', |
There was a problem hiding this comment.
Suggested change
| 'subtitle' => 'Appwrite\'s cache edge sync Endpoint', | |
| 'subtitle' => 'TBD, |
| 'key' => 'edge', | ||
| 'name' => 'edge', | ||
| 'subtitle' => 'Appwrite\'s cache edge sync Endpoint', | ||
| 'description' => 'Cache edge sync Endpoint', |
There was a problem hiding this comment.
Suggested change
| 'description' => 'Cache edge sync Endpoint', | |
| 'description' => 'TBD', |
| ->action(function (Request $request) { | ||
|
|
||
| $token = $request->getHeader('authorization'); | ||
| $token = str_replace(["Bearer"," "], "", $token); |
There was a problem hiding this comment.
Aren't we missing here a space that needs to be removed?
Authorization: Bearer {token}
app/controllers/api/edge.php
Outdated
Comment on lines
46
to
65
| $fallbackForRedis = AppwriteURL::unparse([ | ||
| 'scheme' => 'redis', | ||
| 'host' => App::getEnv('_APP_REDIS_HOST', 'redis'), | ||
| 'port' => App::getEnv('_APP_REDIS_PORT', '6379'), | ||
| 'user' => App::getEnv('_APP_REDIS_USER', ''), | ||
| 'pass' => App::getEnv('_APP_REDIS_PASS', ''), | ||
| ]); | ||
|
|
||
| $connection = App::getEnv('_APP_CONNECTIONS_QUEUE', $fallbackForRedis); | ||
| $dsns = explode(',', $connection ?? ''); | ||
|
|
||
| if (empty($dsns)) { | ||
| Console::error("No Dsn found"); | ||
| } | ||
|
|
||
| $dsn = explode('=', $dsns[0]); | ||
| $dsn = $dsn[1] ?? ''; | ||
| $dsn = new DSN($dsn); | ||
|
|
||
| $client = new SyncIn('syncIn', new QueueRedis($dsn->getHost(), $dsn->getPort())); |
There was a problem hiding this comment.
This is not how we should implement it. By doing this, you create a new Redis connection on every API call. This should be handled as a resource that can use dependency injection.
app/workers/sync-In.php
Outdated
| } | ||
|
|
||
| global $register; | ||
| global $dsn; |
There was a problem hiding this comment.
Use dependency injection, even if need to copy-paste. We are working on a mechanism for share dependencies between http, realtime, workers, cli.
| * @throws Structure | ||
| * @throws Exception | ||
| */ | ||
| function handle($dbForConsole, $regions, $stack): void |
There was a problem hiding this comment.
Very generic name. Let's try to find a better one.
…t-redis-sync � Conflicts: � .env � Dockerfile � app/cli.php � app/init.php � app/preload.php � app/worker.php � composer.json � composer.lock � src/Appwrite/Platform/Tasks/Maintenance.php � src/Appwrite/Platform/Tasks/sync-edge.php
…t-redis-sync � Conflicts: � app/config/regions.php � app/init.php � composer.lock � docker-compose.yml
…t-redis-sync � Conflicts: � composer.lock � docker-compose.yml
shimonewman
changed the base branch from
feat-db-pools-eldad
to
feat-db-pools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.