Refactor functions worker #4659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meldiron
reviewed
Nov 10, 2022
Meldiron
reviewed
Nov 10, 2022
Meldiron
reviewed
Nov 10, 2022
Meldiron
reviewed
Nov 10, 2022
Meldiron
reviewed
Nov 10, 2022
Meldiron
reviewed
Nov 10, 2022
Meldiron
reviewed
Nov 10, 2022
Meldiron
reviewed
Nov 10, 2022
Meldiron
reviewed
Nov 10, 2022
Meldiron
reviewed
Nov 10, 2022
Meldiron
reviewed
Nov 10, 2022
shimonewman
changed the base branch from
feat-db-pools-eldad
to
refactor-scheduler
1 task
eldadfux
requested changes
Nov 15, 2022
Meldiron
approved these changes
Nov 16, 2022
app/workers/builds.php
Outdated
| $connection = $pools->get('queue')->pop(); | ||
| $functions = new Func($connection->getResource()); | ||
| $functions | ||
| ->setData(\json_encode($data)) |
There was a problem hiding this comment.
We dont need to set data. We need to set the payload for events
app/init.php
Outdated
| @@ -563,6 +565,7 @@ function (mixed $value) { | |||
| $dsns = $connection['dsns'] ?? ''; | |||
| $multipe = $connection['multiple'] ?? false; | |||
| $schemes = $connection['schemes'] ?? []; | |||
| $useResource = $connection['useResource'] ?? true; | |||
There was a problem hiding this comment.
This is unused. lets remove it
app/worker.php
Outdated
| Console::error('[Error] File: ' . $error->getFile()); | ||
| Console::error('[Error] Line: ' . $error->getLine()); | ||
|
|
||
| $register->get('pools')->reclaim(); |
There was a problem hiding this comment.
lets remove this. We dont use any pools here
app/worker.php
Outdated
| ->error() | ||
| ->inject('error') | ||
| ->inject('logger') | ||
| ->inject('register') |
There was a problem hiding this comment.
lets remove this injection as well
app/worker.php
Outdated
| $log->setVersion($version); | ||
| $log->setType(Log::TYPE_ERROR); | ||
| $log->setMessage($error->getMessage()); | ||
| $log->setAction('appwrite-worker-functions'); |
There was a problem hiding this comment.
This is no longer appwrite-worker-functions
christyjacob4
approved these changes
Nov 16, 2022
Meldiron
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring functions worker