Feat refactor tasks only using platform library #4665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at-refactor-tasks
…at-refactor-tasks
…at-refactor-tasks
…at-refactor-tasks
…at-refactor-tasks
…rite into feat-refactor-tasks
…at-refactor-tasks
…at-refactor-tasks
…at-refactor-tasks
…at-refactor-tasks
eldadfux
reviewed
Nov 14, 2022
src/Appwrite/CLI/TasksService.php
Outdated
| { | ||
| $this->type = self::TYPE_CLI; | ||
| $this | ||
| ->addAction(Version::getName(), new Version()) |
There was a problem hiding this comment.
Rethinking about this. Do we still need the name if it's part of the interface? Can't we just take it inside the constructor?
There was a problem hiding this comment.
If we do that. I think we can change getName to not be a static class.
There was a problem hiding this comment.
what do we do? move getName as instance function? that will have to be done in the Action and we need the name in order to reference the action, later to remove action?
Not sure I fully understand this
There was a problem hiding this comment.
We need to get them for overwriting them, right?
We could still overwrite them by creating an action with the same name. Do you think it will work?
Co-authored-by: Eldad A. Fux <eldad.fux@gmail.com>
eldadfux
approved these changes
Nov 14, 2022
christyjacob4
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors tasks in Appwrite using the new Platform library
Test Plan
Existing tests
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
YES